[FFmpeg-devel] [PATCH] lavfi: Port mp=pp7 to libavfilter

[Stefano Sabatini]

On date Monday 2014-12-29 10:20:26 +0100, Stefano Sabatini encoded:
> On date Sunday 2014-12-28 19:45:18 +0530, arwa arif encoded:
> [...]
> > From ebf5f36d9e9fc80264bb605dfee5c09cbf1f10ef Mon Sep 17 00:00:00 2001
> > From: Arwa Arif <arwaarif1994 at gmail.com>
> > Date: Thu, 25 Dec 2014 09:50:24 +0530
> > Subject: [PATCH] lavfi: port mp=pp7 to avfilter
> > 
> 
> > Added use_bframe_qp in the list of options.
> 

> Also, add use_bframe_qp option.

Please remove this and add it on top of the pp7 port patch.
 
> I'd also suggest to implement this on top of the port.
> 
> > TODO: modify version.h, Add ff_norm_qscale in internal.h
> > ---
> >  LICENSE.md               |    1 +
> >  configure                |    1 +
> >  doc/filters.texi         |   31 ++++
> >  libavfilter/Makefile     |    1 +
> >  libavfilter/allfilters.c |    1 +
> >  libavfilter/vf_pp7.c     |  460 ++++++++++++++++++++++++++++++++++++++++++++++
> >  libavfilter/vf_pp7.h     |   49 +++++
> >  libavfilter/x86/Makefile |    1 +
> >  libavfilter/x86/vf_pp7.c |   68 +++++++
> >  9 files changed, 613 insertions(+)
> >  create mode 100644 libavfilter/vf_pp7.c
> >  create mode 100644 libavfilter/vf_pp7.h
> >  create mode 100644 libavfilter/x86/vf_pp7.c
> 
> [...]
> 
> It is not bitexact here.
> 
> ffmpeg -i matrixbench_mpeg2-lq.mpg -vf mp=pp7=30 -t 2 -f md5 -
> [...]
> MD5=b281d6e4c077f4bf992dae262bc1cd3e
> 
> ffmpeg -i matrixbench_mpeg2-lq.mpg -vf pp7=30 -t 2 -f md5 -
> [...]
> MD5=0fbf1414f026ad10e76acfc03175b37a

Keep in mind that the difference may be due to the QP information
missing in mp=pp7. So you should focus on that (try to reset/disable
qp processing in pp7 and see if it works the same as mp=pp7).
-- 
FFmpeg = Foolish and Frenzy Mystic Puritan Elitist Geisha