[FFmpeg-devel] [PATCH] Support BMP files that do not properly align lines.

Michael Niedermayer michaelni at gmx.at
Tue Jan 27 22:32:10 CET 2015


On Tue, Jan 27, 2015 at 09:25:29PM +0100, Reimar Döffinger wrote:
> On Tue, Jan 27, 2015 at 09:50:26PM +0100, Michael Niedermayer wrote:
> > On Tue, Jan 27, 2015 at 06:38:22AM +0100, Reimar Döffinger wrote:
> > > On 26.01.2015, at 22:49, Michael Niedermayer <michaelni at gmx.at> wrote:
> > > > On Mon, Jan 26, 2015 at 08:21:16PM +0100, Reimar Döffinger wrote:
> > > >> Quite a few programs missed that detail of the spec
> > > >> (including old versions of FFmpeg I believe) and when
> > > >> we would otherwise fail anyway it seems worth a try
> > > >> to us a simple byte-aligned stride instead.
> > > >> 
> > > >> Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
> > > >> ---
> > > >> libavcodec/bmp.c | 10 +++++++---
> > > >> 1 file changed, 7 insertions(+), 3 deletions(-)
> > > > 
> > > > should be ok, do you have a file that needs this ?
> > > 
> > > Yes, the game X-Wing Alliance creates such files as screenshots if you hack to use affected resolutions.
> > > You can discuss whether they forgot about it or left it out because it doesn't "officially" support such resolutions.
> > > Or do you mean because you'd like a test-case? That should be possible to get.
> > 
> > i wanted a testcase, yes, but its not really important if its correct
> 
> Here:
> http://ffmpeg.org/~reimar/flightscreen16.bmp

thanks, works fine, patch ok

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

DNS cache poisoning attacks, popular search engine, Google internet authority
dont be evil, please
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150127/21cbee2d/attachment.asc>


More information about the ffmpeg-devel mailing list