[FFmpeg-devel] [PATCH 1/1] Extended ASF functionality

[Hendrik Leppkes]

On Wed, Jul 1, 2015 at 6:11 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Wed, Jul 01, 2015 at 06:33:52PM +0300, Vadim Belov wrote:
>> ---
>>  libavformat/Makefile             |   2 +-
>>  libavformat/asf.c                |   4 +
>>  libavformat/asf.h                |  12 ++-
>>  libavformat/asf_ex.h             |  58 ++++++++++
>>  libavformat/asf_trim.c           | 228 +++++++++++++++++++++++++++++++++++++++
>>  libavformat/asf_trim.h           |  95 ++++++++++++++++
>>  libavformat/asfdec.c             |  17 ++-
>>  libavformat/asfenc.c             |  64 ++++++++++-
>>  8 files changed, 954 insertions(+), 485 deletions(-)
>>  create mode 100644 libavformat/asf_ex.h
>>  create mode 100644 libavformat/asf_trim.c
>>  create mode 100644 libavformat/asf_trim.h
>>
>>  1.9.5.msysgit.1
>>
>> diff --git a/ffmpeg.c b/ffmpeg.c
>> index a89ae39..a3cca09 100644
>> --- a/ffmpeg.c
>> +++ b/ffmpeg.c
>
> there is something wrong with the patch
> this hunk changes ffmpeg.c, yet that is not in the stats above
> the change to ffmpeg.c doesnt belong in the patch
>
> also the patch still contain sprintf(), tabs and other issues
> is this the patch you wanted to post or an old one ?
>

Maybe you could also explain what this thing does?
The only comment I saw elsewhere was "ASF streams metadata copy", but
this patch is huge, hundreds of lines of new code. I cannot believe
that copying metadata from one asf file into another would require
these many changes.

So please elaborate what this is doing and what the changes add to our code.

- Hendrik