[FFmpeg-devel] [PATCH 1/4] concatdec: add support for specifying inpoint of files

Nicolas George george at nsup.org
Mon Jul 6 19:25:38 CEST 2015


L'octidi 18 messidor, an CCXXIII, Marton Balint a écrit :
> Signed-off-by: Marton Balint <cus at passwd.hu>
> ---
>  doc/demuxers.texi       | 17 +++++++++++++++++
>  libavformat/concatdec.c | 48 +++++++++++++++++++++++++++++++++++-------------
>  2 files changed, 52 insertions(+), 13 deletions(-)

I like the feature, but I find the name of the directive, "in", too generic.
Maybe "seek" is the best choice?

Also, the timestamp computation code is starting to be a bit complex. Maybe
now is a good time to move file_start_time to the per-file structure. But I
will not consider this blocking.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150706/e19eaabb/attachment.sig>


More information about the ffmpeg-devel mailing list