[FFmpeg-devel] [PATCH] avformat: increase first_frames threshold for mp3, ac3

[Michael Niedermayer]

On Fri, Jul 17, 2015 at 10:23:11PM -0400, Ganesh Ajjanagadde wrote:
> Attached patch is a quick fix for Ticket4723.
> I have a couple of issues with this though:

> 1. It seems like probe thresholds are essentially tweaked based on
> what files are encountered, and that these can't be set precisely
> according to a spec.
> Is this correct?

yes


> 
> 2. Comment in the file mentions keeping probing in sync across ac3/mp3.
> I kept this in mind for the patch, but don't know the rationale for this.
> 
> 2. I tested the patch with fate and against the ticket.
> However, ideally this should be tested against a variety of mp3/ac3 files,
> to make sure the probing still works even with this stricter threshold
> for detection.

> Where can I find comprehensive sample files for this purpose,
> and more generally audio/video files for ffmpeg development?

i tested it a bit and it seems fine
you can find samples at http://samples.ffmpeg.org/

patch applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150718/e92d7177/attachment.sig>