[FFmpeg-devel] [PATCH] Replace AV_PKT_DATA_QUALITY_FACTOR by AV_PKT_DATA_QUALITY_STATS

James Almer jamrial at gmail.com
Wed Jul 22 19:53:06 CEST 2015


On 22/07/15 2:47 PM, Michael Niedermayer wrote:
> On Tue, Jul 21, 2015 at 02:10:56PM +0200, Michael Niedermayer wrote:
>> On Tue, Jul 21, 2015 at 01:41:59PM +0200, Nicolas George wrote:
>>> Le tridi 3 thermidor, an CCXXIII, Michael Niedermayer a écrit :
>>>> -    AV_PKT_DATA_QUALITY_FACTOR,
>>>> +    AV_PKT_DATA_QUALITY_STATS,
>>>
>>>> +#define AV_PKT_DATA_QUALITY_FACTOR please_use_AV_PKT_DATA_QUALITY_STATS_which_is_a_superset_of_it
>>>
>>> It breaks source compatibility with the fork. Is it on purpose? Is there a
>>> drawback in making AV_PKT_DATA_QUALITY_FACTOR a synonym of
>>> AV_PKT_DATA_QUALITY_STATS (possibly with a deprecation warning if possible)
>>> instead?
>>
>> i wasnt sure how to make it show a deprecation warning, do you
>> have an idea ?
>>
>> the drawback without any warning is that endianness mismatches on big
>> endian and that could lead to bugs
> 
> applied and left it as synonym, if someone knows how to deprecate a
> preprocessor symbol please do
> we can also still remove the synonym if people prefer
> 
> Thanks

Both GCC and MSVC let you in theory deprecate enumerators

https://gcc.gnu.org/onlinedocs/gcc/Enumerator-Attributes.html
https://msdn.microsoft.com/en-us/library/c8xdzzhh.aspx

I tried the example shown there for GCC but it didn't work. I may
have done something wrong, though.


More information about the ffmpeg-devel mailing list