[FFmpeg-devel] [PATCH 7/8] tests: Add aac_fixed decoder test

Michael Niedermayer michael at niedermayer.cc
Sat Jul 25 22:48:01 CEST 2015


Hi
On Sat, Jul 25, 2015 at 05:37:56AM +0200, Michael Niedermayer wrote:
> On Mon, Jul 20, 2015 at 01:36:21PM +0200, Nedeljko Babic wrote:
> > Signed-off-by: Nedeljko Babic <nedeljko.babic at imgtec.com>
> > ---
> >  tests/fate/aac.mak | 58 +++++++++++++++++++++++++++++++++++++++++++++++++++++-
> >  1 file changed, 57 insertions(+), 1 deletion(-)
> 
> these tests fail on clang with -ftrapv
> see
> http://fate.ffmpeg.org/report.cgi?time=20150723144015&slot=x86_64-freebsd10-clang33-ftrapv

i fixed one ftrapv issue but a 2nd remains, it seems the code
filters uninitialized and then not used data. Please fix this
unless someone else does before

also SBR seems to fails on ARM
http://fate.ffmpeg.org/report.cgi?time=20150725003242&slot=armv7l-panda-gcc4.6-armv5
it does pass under qemu ARM though it seems
i did test your code on qemu arm not actual arm before i pushed, didnt
thought that would make a difference


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150725/7c334d08/attachment.sig>


More information about the ffmpeg-devel mailing list