[FFmpeg-devel] Fwd: [PATCH 1/2] ffmpeg: reset tty state correctly

[Nicolas George]

Le nonidi 9 thermidor, an CCXXIII, Ganesh Ajjanagadde a écrit :
> > ttyctl -f
> Sure, but this is a command invoked once ffmpeg exits.

This is a command that should be present in everybody's .zshrc.

> What I meant to say was that ffmpeg changes tty state,
> and upon a sigsegv, it did not change the state back, leaving  the
> terminal messed up.

Yes. Like all programs that change the tty state and crash. FFmpeg is not
special, and should not act special.

> The point of this patch is to try to fix 2964 while still not
> clobbering the terminal.

As I told you, 2964 would be fixed by checking only stdin when changing the
input-related tty options.

> BTW, I do not know whose responsibility this is (process or shell invoking it):

Since there are uncatchable signals, it can only be the responsibility of
the shell. Apparently, only the authors of zsh and a few users realized
that.

> Ok. But then you realize that there is no solution that will fix 2964

There is no solution that will avoid leaving the tty in a changed state on a
crash, which is perfectly normal: this is a crash.

> Agreed completely, I do not like this ugly hack,
> and wanted to clarify the hack needed to disable this warning.
> BTW, it is actually more of a glibc thing,
> as seen from the GCC bugzilla discussion:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25509

IIRC, the GNU guys are very fond of sending passing each other the blame to
avoid fixing bugs.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150727/e9f252ae/attachment.sig>