[FFmpeg-devel] Test case for Closed caption decoder.

[Anshul]

On 05/31/2015 06:53 PM, Michael Niedermayer wrote:
> On Sun, May 31, 2015 at 01:59:44PM +0200, Clément Bœsch wrote:
>> On Tue, May 05, 2015 at 08:37:03PM +0530, Anshul wrote:
>>>
>>> On 05/05/2015 08:33 PM, Anshul wrote:
>>>>
>>>> On 05/04/2015 08:50 PM, Michael Niedermayer wrote:
>>>>> this is 31mb, that does not seem reasonable for a subtitle test,
>>>>> please provide a smaller file, like one without unused/untested
>>>>> video streams or a shorter one
>>>>>
>>>>> also fate fails with the patch applied
>>>>> probably line endings arent preserved somewhere, probably best to
>>>>> push to github and post a link
>>>>>
>>>>>
>>>> I have created pull request here.
>>>> https://github.com/FFmpeg/FFmpeg/pull/136
>>>>
>>>> and here is shorter file then previous one.
>>>> http://gsocdev.ccextractor.org/~anshul/test_video/Closedcaption_atsc_rollup.ts
>>>>
>>>> -Anshul
>>> Apology: Forgot to attach new patch for short File.
>>>
>>> -Anshul
>>>
>>>  From 052f5c9e805f20450f33ed64c5043b862c70abd0 Mon Sep 17 00:00:00 2001
>>> From: Anshul Maheshwari <er.anshul.maheshwari at gmail.com>
>>> Date: Tue, 5 May 2015 20:20:09 +0530
>>> Subject: [PATCH] Adding Fate test for ClosedCaption
>>>
>>> Signed-off-by: Anshul Maheshwari <er.anshul.maheshwari at gmail.com>
>>> ---
>>>   tests/fate/subtitles.mak |  3 +++
>>>   tests/ref/fate/sub-cc    | 16 ++++++++++++++++
>>>   2 files changed, 19 insertions(+)
>>>   create mode 100644 tests/ref/fate/sub-cc
>>>
>>> diff --git a/tests/fate/subtitles.mak b/tests/fate/subtitles.mak
>>> index 07d886a..dddf33d 100644
>>> --- a/tests/fate/subtitles.mak
>>> +++ b/tests/fate/subtitles.mak
>>> @@ -1,6 +1,9 @@
>>>   FATE_SUBTITLES_ASS-$(call ALLYES, AQTITLE_DEMUXER TEXT_DECODER ICONV) += fate-sub-aqtitle
>>>   fate-sub-aqtitle: CMD = fmtstdout ass -sub_charenc windows-1250 -i $(TARGET_SAMPLES)/sub/AQTitle_capability_tester.aqt
>>>   
>>> +FATE_SUBTITLES_ASS-$(call ALLYES, CCAPTION_DECODER MOVIE_FILTER MPEGTS_DEMUXER) += fate-sub-cc
>>> +fate-sub-cc: CMD = fmtstdout ass -f lavfi -i "movie=$(TARGET_SAMPLES)/sub/Closedcaption_atsc_rollup.ts[out0+subcc]"
>>> +
>>>   FATE_SUBTITLES_ASS-$(call DEMDEC, JACOSUB, JACOSUB) += fate-sub-jacosub
>>>   fate-sub-jacosub: CMD = fmtstdout ass -i $(TARGET_SAMPLES)/sub/JACOsub_capability_tester.jss
>>>   
>>> diff --git a/tests/ref/fate/sub-cc b/tests/ref/fate/sub-cc
>>> new file mode 100644
>>> index 0000000..02d207e
>>> --- /dev/null
>>> +++ b/tests/ref/fate/sub-cc
>>> @@ -0,0 +1,16 @@
>>> +[Script Info]
>>> +; Script generated by FFmpeg/Lavc
>>> +ScriptType: v4.00+
>>> +PlayResX: 384
>>> +PlayResY: 288
>>> +
>>> +[V4+ Styles]
>>> +Format: Name, Fontname, Fontsize, PrimaryColour, SecondaryColour, OutlineColour, BackColour, Bold, Italic, Underline, StrikeOut, ScaleX, ScaleY, Spacing, Angle, BorderStyle, Outline, Shadow, Alignment, MarginL, MarginR, MarginV, Encoding
>>> +Style: Default,Arial,16,&Hffffff,&Hffffff,&H0,&H0,0,0,0,0,100,100,0,0,1,1,0,2,10,10,10,0
>>> +
>>> +[Events]
>>> +Format: Layer, Start, End, Style, Name, MarginL, MarginR, MarginV, Effect, Text
>>> +Dialogue: 0,0:00:00.83,0:00:02.34,Default,,0,0,0,,( explosion )
>>> +Dialogue: 0,0:00:02.34,0:00:04.47,Default,,0,0,0,,( explosion )\N( inaudible radio chatter )
>>> +Dialogue: 0,0:00:04.47,0:00:05.84,Default,,0,0,0,,( inaudible radio chatter )\N>> Safety remains our number one
>>> +Dialogue: 0,0:00:05.84,0:00:07.31,Default,,0,0,0,,>> Safety remains our number one\Npriority.
>> So what's the state of this patch and the sample? Can it be applied?
> state is: waiting for a sample to be provided to me so i can upload it
>

can you provide me link of carl file you said it was smallest, I would 
make that test case again
with carl file.

-Anshul