[FFmpeg-devel] [PATCH] avformat/mxfdec: Change version byte for JPEG2000 to match mxf.c and RP224v12

tim nicholson nichot20 at yahoo.com
Tue Jun 16 08:26:18 CEST 2015


On 15/06/15 13:13, Michael Niedermayer wrote:
> This should make no difference as the byte is ignored
> 
> Found-by: tim nicholson <nichot20 at yahoo.com>
> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> ---
>  libavformat/mxfdec.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> index 7389555..b3c25b7 100644
> --- a/libavformat/mxfdec.c
> +++ b/libavformat/mxfdec.c
> @@ -1156,7 +1156,7 @@ static const MXFCodecUL mxf_data_essence_container_uls[] = {
>  };
>  
>  static const MXFCodecUL mxf_codec_uls[] = {
> -    { { 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x09,0x04,0x01,0x02,0x02,0x03,0x01,0x01,0x00 }, 14,   AV_CODEC_ID_JPEG2000 },
> +    { { 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x07,0x04,0x01,0x02,0x02,0x03,0x01,0x01,0x00 }, 14,   AV_CODEC_ID_JPEG2000 },
>      { { 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00 },  0,      AV_CODEC_ID_NONE },
>  };
>  
> 
LGTM ;)

Also just noticed that we now have both "MXFCodecUL ff_mxf_codec_uls[]"
and "MXFCodecUL mxf_codec_uls[]" in the mxf codebase. similar names
similar functionality and one a subset of the other. Yet more UL
confusion in mxf land to eventually untangle.

-- 
Tim.
Key Fingerprint 38CF DB09 3ED0 F607 8B67 6CED 0C0B FC44 8B0B FC83


More information about the ffmpeg-devel mailing list