[FFmpeg-devel] [PATCH] avformat/qcp: s/unsigned int/uint32_t

Paul B Mahol onemda at gmail.com
Tue Jun 16 08:41:53 CEST 2015


Dana 16. 6. 2015. 02:30 osoba "Ronald S. Bultje" <rsbultje at gmail.com>
napisala je:
>
> Hi,
>
> On Mon, Jun 15, 2015 at 12:38 PM, Paul B Mahol <onemda at gmail.com> wrote:
>
> > Signed-off-by: Paul B Mahol <onemda at gmail.com>
> > ---
> >  libavformat/qcp.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavformat/qcp.c b/libavformat/qcp.c
> > index 9e2eedf..e2fd5ff 100644
> > --- a/libavformat/qcp.c
> > +++ b/libavformat/qcp.c
> > @@ -139,7 +139,7 @@ static int qcp_read_packet(AVFormatContext *s,
> > AVPacket *pkt)
> >  {
> >      AVIOContext *pb = s->pb;
> >      QCPContext    *c  = s->priv_data;
> > -    unsigned int  chunk_size, tag;
> > +    uint32_t chunk_size, tag;
> >
> >      while(!avio_feof(pb)) {
> >          if (c->data_size) {
>
>
> Why? Typically people prefer elements sized for platform size, since in
> some cases that may perform better (and unsigned int is guaranteed to be
> >=32bit).

It is simply more used in code.

>
> Ronald
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


More information about the ffmpeg-devel mailing list