[FFmpeg-devel] [FFmpeg-cvslog] avcodec/j2kenc: YUV should not use the ICT

[Michael Niedermayer]

On Fri, Jun 19, 2015 at 08:43:49AM +0200, Clément Bœsch wrote:
> On Fri, Jun 19, 2015 at 05:33:32AM +0200, Michael Niedermayer wrote:
> > ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Fri Jun 19 04:51:59 2015 +0200| [bb3703a4c30659d7ae7b41a94455ce810bbc102b] | committer: Michael Niedermayer
> > 
> > avcodec/j2kenc: YUV should not use the ICT
> > 
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > 
> > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=bb3703a4c30659d7ae7b41a94455ce810bbc102b
> > ---
> > 
> >  libavcodec/j2kenc.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavcodec/j2kenc.c b/libavcodec/j2kenc.c
> > index 68905cc..6a5fd36 100644
> > --- a/libavcodec/j2kenc.c
> > +++ b/libavcodec/j2kenc.c
> > @@ -271,7 +271,7 @@ static int put_cod(Jpeg2000EncoderContext *s)
> >      bytestream_put_byte(&s->buf, 0); // progression level
> >      bytestream_put_be16(&s->buf, 1); // num of layers
> >      if(s->avctx->pix_fmt == AV_PIX_FMT_YUV444P){
> > -        bytestream_put_byte(&s->buf, 2); // ICT
> > +        bytestream_put_byte(&s->buf, 0); // unspecified
> >      }else{
> >          bytestream_put_byte(&s->buf, 0); // unspecified
> >      }
> 
> Any reason to keep the if?

RGB should use the ICT or RCT

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150619/7d70bc0d/attachment.asc>