[FFmpeg-devel] [PATCH] libavformat: Add H264 API test

Vittorio Giovara vittorio.giovara at gmail.com
Mon Jun 22 15:46:17 CEST 2015


On Mon, Jun 22, 2015 at 1:40 PM, Derek Buitenhuis
<derek.buitenhuis at gmail.com> wrote:
> On 6/22/2015 1:32 PM, Vittorio Giovara wrote:
>> video_decode_example can return -1 on error, and this is lost, so
>> you'd better do "return video_decode_example(argv[1]);" to return the
>> value to the caller. Also sometimes you exit(1) and sometimes you
>> return -1, maybe you could go with only one of them.
>
> You shouldn't return -1 as a process exit code. This is a reserved value
> for proc return codes in POSIX.

afaik in POSIX any non zero value is to be considered an error, also
because value ranges on an unsigned byte.
-- 
Vittorio


More information about the ffmpeg-devel mailing list