[FFmpeg-devel] [PATCH] avfilter/vf_psnr & vf_ssim: abort filtering when shortest video ends

[Nicolas George]

Le decadi 10 messidor, an CCXXIII, Paul B Mahol a écrit :
> Can Nicolas comment too?
> I'm not really sure why just 'shortest' is not needed.

I suspect it might be a bug in the options mapping between dualinput and
framesync.

    if (s->shortest)
        in[0].after = in[1].after = EXT_STOP;
    if (!s->repeatlast) {
        in[1].after = EXT_NULL;
        in[1].sync  = 0;
    }

It seems that if repeatlast is 0, then it will overwrite in[1].after. The
code should probably be changed into:

    if (!s->repeatlast) {
	if (!s->shortest)
	    in[1].after = EXT_NULL;

My advice would be to use framesync directly instead of dualinput.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150628/cae767a4/attachment.asc>