[FFmpeg-devel] Patch to parse H264 SEI Green Metadata

Nicolas Derouineau nicolas.derouineau at vitec.com
Tue Jun 30 12:30:50 CEST 2015


>> @@ -475,6 +475,8 @@ per-block quantization parameter (QP)
>>  motion vector
>>  @item dct_coeff
>>
>> + at item green_metadata
>> +
>
>Shouldn't there be some explanation?

Corrected

>> @@ -2610,6 +2610,7 @@ typedef struct AVCodecContext {
>>  #define FF_DEBUG_ER          0x00000400
>>  #define FF_DEBUG_MMCO        0x00000800
>>  #define FF_DEBUG_BUGS        0x00001000
>> +#define FF_DEBUG_GREEN_MD    0x00001200
>
>I believe this has to come at the end of the list with value 0x20000.

Michael Niedermayer has sugested 0x00800000. I'm however going to use the one you suggest (as it is the last comment). Corrected.

>> +        if ( h->sei_green_metadata.green_metadata_type == 2){
>
>Please make this "if (h->sei.. == 2) {" to match the coding style around.

Corrected.

>
>Your av_logs could use a linebreak after the string.

I'm not sure I understand correctly this last comment. I have unified the number of space in the strings.






De : ffmpeg-devel-bounces at ffmpeg.org <ffmpeg-devel-bounces at ffmpeg.org> de la part de Carl Eugen Hoyos <cehoyos at ag.or.at>
Envoyé : mardi 30 juin 2015 11:52
À : FFmpeg development discussions and patches
Objet : Re: [FFmpeg-devel] Patch to parse H264 SEI Green Metadata

On Tuesday 30 June 2015 11:38:03 am Nicolas Derouineau wrote:

> From f7cff28a44adada6761233d59207b4a9c0373960 Mon Sep 17 00:00:00 2001
> From: Nicolas DEROUINEAU <nicolas.derouineau at vitec.com>
> Date: Tue, 30 Jun 2015 10:59:07 +0200
> Subject: [PATCH] Patch to parse SEI GreenMetadata
>
> ---
>  doc/codecs.texi            |    2 ++
>  libavcodec/avcodec.h       |    1 +
>  libavcodec/h264.h          |   21 ++++++++++++++++
>  libavcodec/h264_sei.c      |   59
> ++++++++++++++++++++++++++++++++++++++++++++ libavcodec/options_table.h |
>  1 +
>  5 files changed, 84 insertions(+)
>
> diff --git a/doc/codecs.texi b/doc/codecs.texi
> index 3c035a5..5b3ec9b 100644
> --- a/doc/codecs.texi
> +++ b/doc/codecs.texi
> @@ -475,6 +475,8 @@ per-block quantization parameter (QP)
>  motion vector
>  @item dct_coeff
>
> + at item green_metadata
> +

Shouldn't there be some explanation?

>  @item skip
>
>  @item startcode
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index ddbf0a3..65c9053 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -2610,6 +2610,7 @@ typedef struct AVCodecContext {
>  #define FF_DEBUG_ER          0x00000400
>  #define FF_DEBUG_MMCO        0x00000800
>  #define FF_DEBUG_BUGS        0x00001000
> +#define FF_DEBUG_GREEN_MD    0x00001200

I believe this has to come at the end of the list with value 0x20000.

[...]

> +        if ( h->sei_green_metadata.green_metadata_type == 2){

Please make this "if (h->sei.. == 2) {" to match the coding style around.

Your av_logs could use a linebreak after the string.

Carl Eugen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel at ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Patch-to-parse-SEI-GreenMetadata.patch
Type: text/x-patch
Size: 7358 bytes
Desc: 0001-Patch-to-parse-SEI-GreenMetadata.patch
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150630/8c6127ef/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Correcting-syntax-typo-for-GreenMetadata-SEI-parser.patch
Type: text/x-patch
Size: 5189 bytes
Desc: 0002-Correcting-syntax-typo-for-GreenMetadata-SEI-parser.patch
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150630/8c6127ef/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Correcting-FF_DEBUG_NUMBER-for-GreenMetadata.patch
Type: text/x-patch
Size: 1159 bytes
Desc: 0003-Correcting-FF_DEBUG_NUMBER-for-GreenMetadata.patch
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150630/8c6127ef/attachment-0002.bin>


More information about the ffmpeg-devel mailing list