[FFmpeg-devel] [RFC]Don't use round when encoding png

Michael Niedermayer michaelni at gmx.at
Sun Mar 1 13:08:22 CET 2015


On Sun, Mar 01, 2015 at 12:09:28PM +0100, Carl Eugen Hoyos wrote:
> On Sunday 01 March 2015 11:22:10 am Michael Niedermayer wrote:
> > On Sun, Mar 01, 2015 at 09:44:30AM +0100, Carl Eugen Hoyos wrote:
> > > Attached untested patch should fix compilation on broken platforms.
> > > We don't use round() currently because it appears less portable than
> > > lrintf().
> 
> > yes reducing float code usage should be fine, less potential to
> > cause problems with regression tests
> 
> New patch attached.
> 
> Please review, Carl Eugen

>  pngenc.c |   55 +++++++++++++++++++++++++++----------------------------
>  1 file changed, 27 insertions(+), 28 deletions(-)
> aaeeb2a2e860b60ec403b84980542f97091cc21b  patchpnground.diff
> diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c
> index 9fd8eef..b6eedde 100644

should be ok

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150301/c1bb1cf0/attachment.asc>


More information about the ffmpeg-devel mailing list