[FFmpeg-devel] [PATCH]Do not list mov codecs in riff.c

[Carl Eugen Hoyos]

wm4 <nfxjfg <at> googlemail.com> writes:

> > +    if (!st->codec->codec_id) {
> > +        st->codec->codec_id = ff_codec_get_id(ff_codec_movvideo_tags,
> > +                                              tag1);
> > +        if (st->codec->codec_id)
> > +            av_log(s, AV_LOG_WARNING, "mov tag found in avi\n");
> > +        }
> 
> Nice warning, but why do we accept this in 
> the first place? This looks so very wrong.

I don't understand:
You mean we should change (patch) FFmpeg so 
that it only accepts valid files in the 
future? This is a major task imo given that 
we spent so much time supporting even the 
most broken streams (see ts without PMT / 
PAT).
And how do you define valid? Nowadays, WMP 
plays many files that do not conform to 
standards (including some that FFmpeg 
refuses to decode). I believe FFmpeg should 
not be more strict by default than WMP (or 
QT).

Carl Eugen