[FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

[Michael Niedermayer]

On Mon, Mar 16, 2015 at 11:23:33AM -0500, Jeremy Luce wrote:
> Here is the updated patch with documentation and proper line breaks.
> Jeremy
> 
> 
> On Fri, Mar 13, 2015 at 1:02 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Wed, Mar 11, 2015 at 08:34:39AM -0500, Jeremy Luce wrote:
> >> Resubmitting with [PATCH] tag and unified diff.
> >>
> >> Adds functionality to pause transcoding with 'p' key and upause with 'u'
> >> key over stdin. Pauses in the main transcode loop as well as the
> >> input_thread loop.
> > [...]
> >
> >> @@ -3346,7 +3371,9 @@ static int check_keyboard_interaction(int64_t cur_time)
> >>                          "C      Send/Que command to all matching filters\n"
> >>                          "D      cycle through available debug modes\n"
> >>                          "h      dump packets/hex press to cycle
> >> through the 3 states\n"
> >> +                        "p      pause transcoding\n"
> >
> > this looks like the diff has been corrupted with line breaks
> >
> > also this is missing documentation in doc/*
> >
> > [...]
> > --
> > Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> >
> > I am the wisest man alive, for I know one thing, and that is that I know
> > nothing. -- Socrates
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >

>  doc/ffmpeg.texi |   38 ++++++++++++++++++++++++++++++++++++++
>  ffmpeg.c        |   51 ++++++++++++++++++++++++++++++++++++++++++++++-----
>  2 files changed, 84 insertions(+), 5 deletions(-)
> f4321165de7a06c32e23b05989016f5e9d5158e0  0001-Add-pause-resume-via-keyboard-interaction.patch
> From 8d7f26a99ea0f189968c483b0d5f0cc09a98b5d6 Mon Sep 17 00:00:00 2001
> From: jluce50 <jeremyluce at gmail.com>
> Date: Fri, 6 Mar 2015 17:13:40 -0600
> Subject: [PATCH] Add pause/resume via keyboard interaction. Docs updated to
>  include keyboard interaction (incl. new pause commands)




> 
> ---
>  doc/ffmpeg.texi | 38 ++++++++++++++++++++++++++++++++++++++
>  ffmpeg.c        | 51 ++++++++++++++++++++++++++++++++++++++++++++++-----
>  2 files changed, 84 insertions(+), 5 deletions(-)
> 
> diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi
> index 6772f2f..0001144 100644
> --- a/doc/ffmpeg.texi
> +++ b/doc/ffmpeg.texi
> @@ -1276,6 +1276,44 @@ search for the file @file{libvpx-1080p.avpreset}.
>  If no such file is found, then ffmpeg will search for a file named
>  @var{arg}.avpreset in the same directories.
>  
> + at section While transcoding
> +
> + at table @key
> + at item ?
> +show help
> +
> + at item +
> +increase verbosity
> +
> + at item -
> +decrease verbosity
> +
> + at item d
> +send command to first matching filter supporting it
> +
> + at item C
> +send/queue command to all matching filters
> +
> + at item D
> +cycle through available debug modes
> +
> + at item h
> +packets/hex press to cycle through the 3 states
> +
> + at item p
> +pause transcoding
> +
> + at item q
> +quit
> +

> + at item u
> +unpause transcoding

it seems any key unpauses transcoding

also theres no vissual feedback that ffmpeg is paused or how the
user can unpause it
this is bad in case the user pressed p by mistake

also the c and C keys already effectivly pause ffmpeg
p should not be implemented entirely differently than how they work.
If c/C have problems these problems should be fixed

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150316/44b12dea/attachment.asc>