[FFmpeg-devel] [PATCH 2/4] png: Clearly separate encoding header and frames

[Michael Niedermayer]

On Tue, Mar 31, 2015 at 12:37:23PM +0000, Donny Yang wrote:
> Signed-off-by: Donny Yang <work at kota.moe>
[...]

> +    ret = encode_headers(avctx, pict);
> +    if (ret)
> +        return ret;
> +
> +    ret = encode_frame(avctx, pict);
> +    if (ret)
> +        return ret;

error checks are "< 0" in ffmpeg unless something else is dicatated
by external API

also this fails build:

ffmpeg/libavcodec/pngenc.c: In function ‘encode’:
ffmpeg/libavcodec/pngenc.c:463:46: error: ‘row_size’ undeclared (first use in this function)
ffmpeg/libavcodec/pngenc.c:463:46: note: each undeclared identifier is reported only once for each function it appears in

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150331/3b2b2373/attachment.asc>