[FFmpeg-devel] [PATCH] diracdec: check if reference could not be allocated

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Wed May 6 15:40:25 CEST 2015


On 06.05.2015 02:26, Michael Niedermayer wrote:
> On Tue, May 05, 2015 at 11:51:48PM +0200, Andreas Cadhalpun wrote:
>> s->ref_pics[i] is later used as ref argument of interpolate_refplane,
>> where it is dereferenced.
>>
>> If it is NULL, it causes a segmentation fault.
>>
>> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
>> ---
>>  libavcodec/diracdec.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
> 
> applied
> 
> though i would also prefer more expressive error codes

I agree, but most of that file lacks proper error codes/forwarding.
I'll see if I can fix this properly.

Best regards,
Andreas



More information about the ffmpeg-devel mailing list