[FFmpeg-devel] [PATCH] avcodec/vp9: Use separate memset for counts.eob

Ronald S. Bultje rsbultje at gmail.com
Fri May 15 12:59:50 CEST 2015


Hi,

On Fri, May 15, 2015 at 5:10 AM, Michael Niedermayer <michaelni at gmx.at>
wrote:

> Makes no real difference, but maybe scares coverity less (CID1297578)
>
> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> ---
>  libavcodec/vp9.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c
> index db3f541..4655e9a 100644
> --- a/libavcodec/vp9.c
> +++ b/libavcodec/vp9.c
> @@ -867,7 +867,8 @@ static int decode_frame_header(AVCodecContext *ctx,
>      }
>
>      if (s->keyframe || s->intraonly) {
> -        memset(s->counts.coef, 0, sizeof(s->counts.coef) +
> sizeof(s->counts.eob));
> +        memset(s->counts.coef, 0, sizeof(s->counts.coef));
> +        memset(s->counts.eob,  0, sizeof(s->counts.eob));
>      } else {
>          memset(&s->counts, 0, sizeof(s->counts));
>      }


LGTM.

Ronald


More information about the ffmpeg-devel mailing list