[FFmpeg-devel] [PATCH][GSoC] lavf/http: Parse and set HTTP method when listening on HTTP(S)

Stephan Holljes klaxa1337 at googlemail.com
Fri May 29 16:49:22 CEST 2015


On Fri, May 29, 2015 at 4:34 PM, Stephan Holljes
<klaxa1337 at googlemail.com> wrote:
> On Fri, May 29, 2015 at 4:19 PM, wm4 <nfxjfg at googlemail.com> wrote:
>> On Fri, 29 May 2015 16:12:27 +0200
>> Stephan Holljes <klaxa1337 at googlemail.com> wrote:
>>
>>> Hi,
>>>
>>> On Fri, May 29, 2015 at 11:54 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
>>> > On Fri, May 29, 2015 at 05:05:08AM +0200, Stephan Holljes wrote:
>>> >> Signed-off-by: Stephan Holljes <klaxa1337 at googlemail.com>
>>> >> ---
>>> >>  libavformat/http.c | 8 ++++++++
>>> >>  1 file changed, 8 insertions(+)
>>> >>
>>> >> diff --git a/libavformat/http.c b/libavformat/http.c
>>> >> index 4f6716a..3fad43d 100644
>>> >> --- a/libavformat/http.c
>>> >> +++ b/libavformat/http.c
>>> >> @@ -556,6 +556,14 @@ static int process_line(URLContext *h, char *line, int line_count,
>>> >>
>>> >>      p = line;
>>> >>      if (line_count == 0) {
>>> >> +        if (s->listen) {
>>> >> +            while (!av_isspace(*p))
>>> >> +                p++;
>>> >
>>> >> +            s->method = av_malloc(p - line);
>>> >> +            if (!s->method)
>>> >> +                return AVERROR(ENOMEM);
>>> >> +            av_strlcpy(s->method, line, p - line + 1);
>>> >
>>> > the allocated size and the size passed to av_strlcpy() should match
>>>
>>> Attached patch fixes that.
>>>
>>
>> av_strndup?
>
> That looks a lot more suited. Will change the code accordingly.
>

Attached patch makes use of av_strndup.

>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavf-http-Parse-and-set-HTTP-method-when-listening-o.patch
Type: text/x-patch
Size: 937 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150529/c4b57a33/attachment.bin>


More information about the ffmpeg-devel mailing list