[FFmpeg-devel] [libav-devel] [PATCH] libopenjpegdec: check existence of image component data

[Andreas Cadhalpun]

On 30.05.2015 19:21, Michael Niedermayer wrote:
> On Sat, May 30, 2015 at 10:09:54AM -0700, Michael Bradshaw wrote:
>> On Sat, May 30, 2015 at 7:50 AM, Andreas Cadhalpun <
>> andreas.cadhalpun at googlemail.com> wrote:
>>
>>> On 30.05.2015 16:41, Luca Barbato wrote:
>>>> Do you happen to know why it does do that?
>>>
>>> It encounters a problem, but only warns about it and returns the image
>>> anyway. The warning is not sent to stdout with libavcodec, but can be seen
>>> with j2k_dump:
>>> [WARNING] 0000006a: expected a marker instead of 0
>>
>>
>> Then perhaps a opj_event_mgr_t event handler should be registered. The
>> openjpeg encoder does this to log all warnings with av_log.
> 
>> But if openjpeg
>> is giving back bad data without a warning/error code from the returning
>> function, then perhaps this error check is justified.
> 
> i think so too

So OK to push?

Best regards,
Andreas