[FFmpeg-devel] [PATCH 3/4] avutil/eval: check av_expr_parse_and_eval error code in the test build

[Michael Niedermayer]

On Sat, Oct 31, 2015 at 10:47:56AM -0400, Ganesh Ajjanagadde wrote:
> This returns the error code from main in the test, in this case ENOMEM.
> This should not matter, and will ensure that no warnings are triggered
> when av_warn_unused_result is added to avutil/eval.h.
> 
> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
> ---
>  libavutil/eval.c | 22 +++++++++++++---------
>  1 file changed, 13 insertions(+), 9 deletions(-)

breaks fate

TEST    eval
--- ./tests/ref/fate/eval       2015-10-30 03:22:52.209691909 +0100
+++ tests/data/fate/eval        2015-11-01 18:48:37.730502524 +0100
@@ -1,281 +1 @@
 Evaluating ''
-'' -> nan
-
-Evaluating '1;2'
-'1;2' -> 2.000000
-
-Evaluating '-20'
-'-20' -> -20.000000
-
-Evaluating '-PI'
-'-PI' -> -3.141593
-
[...]
-12.700000 == 12.7
-0.931323 == 0.931322575
Test eval failed. Look at tests/data/fate/eval.err for details.
make: *** [fate-eval] Error 234
make: *** Waiting for unfinished jobs....

cat tests/data/fate/eval.err
[Eval @ 0x7ffe40285770] Undefined constant or missing '(' in ''

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151101/eba95377/attachment.sig>