[FFmpeg-devel] [PATCH 2/4] avcodec/faandct: use typedef instead of #define

[Ganesh Ajjanagadde]

On Sun, Nov 15, 2015 at 8:43 PM, Ganesh Ajjanagadde <gajjanag at mit.edu> wrote:
> On Sun, Nov 15, 2015 at 8:33 PM, Michael Niedermayer
> <michael at niedermayer.cc> wrote:
>> On Sun, Nov 15, 2015 at 10:33:10AM -0500, Ganesh Ajjanagadde wrote:
>>> On Fri, Nov 13, 2015 at 12:05 PM, Ganesh Ajjanagadde <gajjanag at mit.edu> wrote:
>>> > On Fri, Nov 13, 2015 at 11:58 AM, Nicolas George <george at nsup.org> wrote:
>>> >> Le tridi 23 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit :
>>> >>> See e.g https://stackoverflow.com/questions/1666353/are-typedef-and-define-the-same-in-c
>>> >>> for rationale.
>>> >>>
>>> >>> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
>>> >>> ---
>>> >>>  libavcodec/faandct.c | 2 +-
>>> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>> >>
>>> >> Any reason not to just replace FLOAT with float and be done?
>>> >
>>> > Assumed Michael kept it open in case we wish to transition to double
>>> > precision, in which case diff would be smaller. If float is all we
>>> > want for the foreseeable future, will change on your lines.
>>>
>>> @Michael: are you fine with replacing all FLOAT with float?
>>
>> having FLOAT allows easily switching it to double if someone wants
>> to test something with higher precission.
>> I dont know how useful that is, or how often it would be used or
>> if it will never be used
>
> I myself am fine with either, but I want the #define gone. Unless
> Nicolas objects strongly to the patch as is, will push.

No response from Nicolas, so viewed it as a lack of a strong
objection. Maintainer seems fine with it, so pushed.

>
>>
>> [...]
>> --
>> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>>
>> The real ebay dictionary, page 1
>> "Used only once"    - "Some unspecified defect prevented a second use"
>> "In good condition" - "Can be repaird by experienced expert"
>> "As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>