[FFmpeg-devel] [PATCH v2 01/13] Rename mipsdspr1 to mipsdsp

Michael Niedermayer michael at niedermayer.cc
Wed Nov 18 17:57:52 CET 2015


On Wed, Nov 18, 2015 at 11:13:37AM +0000, Vicente Olivert Riera wrote:
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera at imgtec.com>
> ---
> Changes v1 -> v2:
>  - Remove a block of code for mipsdspr2 which wasn't intended to be in
>    this patch and it was causing a syntax error in the configure script.
>    Highlighted by Michael Niedermayer:
>    https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2015-November/183444.html
> 
>  Makefile                                  |    2 +-
>  arch.mak                                  |    2 +-
>  configure                                 |   28 ++++++++++++++--------------
>  libavcodec/aacenc.c                       |    2 +-
>  libavcodec/mips/Makefile                  |    4 ++--
>  libavcodec/mips/ac3dsp_mips.c             |    4 ++--
>  libavcodec/mips/mpegaudiodsp_mips_fixed.c |    2 +-
>  libavcodec/mpegaudiodec_template.c        |    4 ++--
>  libavcodec/mpegaudiodsp.c                 |    2 +-
>  libavcodec/mpegaudiodsp.h                 |    2 +-
>  10 files changed, 26 insertions(+), 26 deletions(-)

Changed or removed configure options should be documented
not sure where but maybe some release notes

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151118/70b6868c/attachment.sig>


More information about the ffmpeg-devel mailing list