[FFmpeg-devel] [PATCH] ffmpeg: enable echoing with command and debug modes

Michael Niedermayer michaelni at gmx.at
Thu Nov 19 23:16:46 CET 2015


On Thu, Nov 19, 2015 at 10:54:45PM +0100, Clément Bœsch wrote:
> Allow seeing text when pressing 'c' or 'd'.
> ---
>  ffmpeg.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)

> 
> diff --git a/ffmpeg.c b/ffmpeg.c
> index c4e9280..8d558e3 100644
> --- a/ffmpeg.c
> +++ b/ffmpeg.c
> @@ -3395,6 +3395,18 @@ static OutputStream *choose_output(void)
>      return ost_min;
>  }
>  
> +static void set_tty_echo(int on)
> +{
> +#if HAVE_TERMIOS_H
> +    struct termios tty;
> +    if (tcgetattr(0, &tty) == 0) {
> +        if (on) tty.c_lflag |= ECHO;
> +        else    tty.c_lflag &= ~ECHO;
> +        tcsetattr(0, TCSANOW, &tty);
> +    }

this might need a if !run_as_daemon
otherwise LGTM but my knowledge about ttys is limited so maybe
wait a bit so otthers have a chance to comment

also tested & works
thanks!

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151119/c1fb4d6b/attachment.sig>


More information about the ffmpeg-devel mailing list