[FFmpeg-devel] [PATCH 2/5] concatdec: calculate duration early if outpoint is known

Nicolas George george at nsup.org
Sun Nov 22 19:40:46 CET 2015


Sorry, missed this reply.

> In read_header, duration is only set if both inpoint and outpoint is set by
> the user.
> 
> In open_file duration is set if outpoint is set by the user which is the
> superset of the first case.

Ok, I think I was confused by the similar inpoint / file_inpoint field
names. At some point, renaming the second one to maybe ts_origin, or maybe
ts_delta (changing the logic a bit) would probably a good idea.

In the meantime, no objection to this patch.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151122/eebd1d4c/attachment.sig>


More information about the ffmpeg-devel mailing list