[FFmpeg-devel] [PATCH] blockdsp: remove high bit depth parameter

[Michael Niedermayer]

On Mon, Sep 28, 2015 at 06:51:07PM +0200, Christophe Gisquet wrote:
> This parameter is intended for pixel data, while the functions are
> actually only called for dct blocks.
> 
> I admit I haven't run this over all of fate, so it would be nice to
> validate nothing actually uses it for pixels (I have see nothing of
> the sort).
> 
> -- 
> Christophe

>  alpha/blockdsp_alpha.c    |    4 +---
>  arm/blockdsp_init_arm.c   |    4 ++--
>  arm/blockdsp_init_neon.c  |    4 +---
>  blockdsp.c                |   20 +++++++++-----------
>  blockdsp.h                |   10 +++++-----
>  mips/blockdsp_init_mips.c |   12 +++++-------
>  ppc/blockdsp.c            |    5 +----
>  x86/blockdsp_init.c       |    4 +---
>  8 files changed, 25 insertions(+), 38 deletions(-)
> da6dcd904d1f1a5fb72e829234c2891b740a5c72  0002-blockdsp-remove-high-bitdepth-parameter.patch
> From d89cdcaf4f71bcb910e57184c2024029f09b3903 Mon Sep 17 00:00:00 2001
> From: Christophe Gisquet <christophe.gisquet at gmail.com>
> Date: Mon, 28 Sep 2015 13:59:23 +0200
> Subject: [PATCH 2/7] blockdsp: remove high bitdepth parameter
> 
> It is only (mis-)used to set the dsp fucntions clear_block(s). But
> these functions always work on 16bits-wide elements, which make
> the parameter useless and actually harmful, as it causes all content
> on more than 8-bits to not use accelerated functions.
> ---
>  libavcodec/alpha/blockdsp_alpha.c    |  4 +---
>  libavcodec/arm/blockdsp_init_arm.c   |  4 ++--
>  libavcodec/arm/blockdsp_init_neon.c  |  4 +---
>  libavcodec/blockdsp.c                | 20 +++++++++-----------
>  libavcodec/blockdsp.h                | 10 +++++-----
>  libavcodec/mips/blockdsp_init_mips.c | 12 +++++-------
>  libavcodec/ppc/blockdsp.c            |  5 +----
>  libavcodec/x86/blockdsp_init.c       |  4 +---
>  8 files changed, 25 insertions(+), 38 deletions(-)

CC      libavcodec/arm/blockdsp_init_arm.o
CC      libavcodec/arm/blockdsp_init_neon.o
ffmpeg/libavcodec/arm/blockdsp_init_neon.c:31:28: error: conflicting types for ‘ff_blockdsp_init_neon’
ffmpeg/libavcodec/arm/blockdsp_arm.h:24:6: note: previous declaration of ‘ff_blockdsp_init_neon’ was here
make: *** [libavcodec/arm/blockdsp_init_neon.o] Error 1
ffmpeg/libavcodec/arm/blockdsp_init_arm.c: In function ‘ff_blockdsp_init_arm’:
ffmpeg/libavcodec/arm/blockdsp_init_arm.c:32:9: error: too few arguments to function ‘ff_blockdsp_init_neon’
ffmpeg/libavcodec/arm/blockdsp_arm.h:24:6: note: declared here
make: *** [libavcodec/arm/blockdsp_init_arm.o] Error 1
make: Target `all' not remade because of errors.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151001/bffb41ce/attachment.sig>