[FFmpeg-devel] [PATCH] avcodec/apedec: fix bug introduced in commit d3e5fbb1406995e07fccbff3ca8c1e24f57a1f7b

[Hendrik Leppkes]

On Sat, Oct 3, 2015 at 2:33 PM, Ganesh Ajjanagadde <gajjanag at mit.edu> wrote:
> On Tue, Sep 29, 2015 at 8:25 PM, Ganesh Ajjanagadde <gajjanag at mit.edu> wrote:
>> On Tue, Sep 29, 2015 at 9:08 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>>> On Tue, Sep 29, 2015 at 07:27:03PM -0400, Ganesh Ajjanagadde wrote:
>>>> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
>>>> ---
>>>>  libavcodec/apedec.c | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> breaks fate
>>>
>>> --- ./tests/ref/fate/lossless-monkeysaudio-399  2015-09-29 13:42:22.893972599 +0200
>>> +++ tests/data/fate/lossless-monkeysaudio-399   2015-09-30 03:06:06.950988548 +0200
>>> @@ -1 +1 @@
>>> -a28d4e5f2192057f7d4bece870f40bd0
>>> +df8663c29d7cd7268d6ae77edd742bb5
>>> Test lossless-monkeysaudio-399 failed. Look at tests/data/fate/lossless-monkeysaudio-399.err for details.
>>> make: *** [fate-lossless-monkeysaudio-399] Error 1
>>
>> Weird, unfortunately for whatever reason my fate does not test this
>> (though apedec gets compiled) so I can't reproduce. One suggestion I
>> have is removing the U at the end, that will prevent any unforeseen
>> signed/unsigned business which I thought was ok. Please change the
>> author tag if you do this.
>
> updated patch removing the U; like I said my fate does not test it so
> it only has been compile tested.
>

You should figure out whats wrong with your FATE, the ape test doesn't
use anything special in particular, so if it isnt running, a bunch of
others may also not be.