[FFmpeg-devel] [PATCH] configure: Add FFMPEG_CONFIGURATION and FFMPEG_LICENSE defines to avconfig.h

Hendrik Leppkes h.leppkes at gmail.com
Fri Oct 9 22:11:36 CEST 2015


On Fri, Oct 9, 2015 at 9:58 PM, Nicolas George <george at nsup.org> wrote:
> L'octidi 18 vendémiaire, an CCXXIV, Gonzalo a écrit :
>> This was sent in another mail, but may be lost since it did not specify a
>> PATCH.
>>
>> The patch is to get the license and compile flags from any application, I
>> add them to the distribution of avconfig.h.
>
>> diff --git a/configure b/configure
>> index b572d59..4196088 100755
>
> You should use git send-email or git format-patch, it includes author
> information and commit message.
>
>> --- a/configure
>> +++ b/configure
>> @@ -6224,6 +6224,8 @@ cat > $TMPH <<EOF
>>  /* Generated by ffconf */
>>  #ifndef AVUTIL_AVCONFIG_H
>>  #define AVUTIL_AVCONFIG_H
>
>> +#define FFMPEG_CONFIGURATION "$(c_escape $FFMPEG_CONFIGURATION)"
>> +#define FFMPEG_LICENSE "$(c_escape $license)"
>>  EOF
>
> This information is already available through avcodec_configuration() and
> avcodec_license(). Do you really need a static version? With a shared
> library, it may not match.
>

I agree, that information is available through the APIs which will
ensure it matches what the binaries were built with. Using those
functions is preferred.

- Hendrik


More information about the ffmpeg-devel mailing list