[FFmpeg-devel] [PATCH] avutil/mathematics: speed up av_gcd by using Stein's binary GCD algorithm

[James Darnley]

On 2015-10-10 23:06, Ganesh Ajjanagadde wrote:
> ...

Is the greatest common denominator (yes, I had to look that up) actually
used anywhere that is slow and needs to be fast?

All the uses of 'av_gcd' found by grep appear be dealing with timing.  I
see framerate, timebase, scale.  I do see uses in rational.c which
implies uses through AVRational, how many codecs are using rational
numbers in their processing?

I think this is a case of premature optimization.

On the other hand if people want to replace the current algorithm then
who am I to stop them.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 603 bytes
Desc: OpenPGP digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151011/365b4fae/attachment.sig>