[FFmpeg-devel] [PATCH 01/10] lavu: add AESNI CPU flag

[Moritz Barsnick]

On Tue, Oct 13, 2015 at 04:27:07 +0200, Michael Niedermayer wrote:
> > @@ -117,6 +117,7 @@ static const struct {
> >      { "SSSE3",    "ssse3",    AV_CPU_FLAG_SSSE3|AV_CPU_FLAG_ATOM },
> >      { "SSE4.1",   "sse4",     AV_CPU_FLAG_SSE4 },
> >      { "SSE4.2",   "sse42",    AV_CPU_FLAG_SSE42 },
> > +    { "AES-NI",   "aesni",    AV_CPU_FLAG_AESNI },
> 
> not 100% sure its this but the - looks like invalid syntax
> -, +, *, /, ... should be avoided

In this case, isn't this just a string used in print_cpu_name()?

BTW, Henrik Gramner pointed out yesterday:

> Should be "AES-NI" with a dash here since that's the official name,
> possibly in a few other places as well (using a dash wherever SSE4.1
> is spelled with dot is probably reasonable).

And Rodger didn't even change it everywhere possible (commit message,
configure output). ;-)

Moritz