[FFmpeg-devel] [PATCH 1/2] ffplay: use AVSubtitleRect.data instead of .pict.data

[wm4]

On Fri, 23 Oct 2015 21:33:49 +0200
Hendrik Leppkes <h.leppkes at gmail.com> wrote:

> On Fri, Oct 23, 2015 at 8:44 PM, Marton Balint <cus at passwd.hu> wrote:
> > Current code segfaults since the deprecation of AVSubtitleRect.pict because it
> > frees/reallocs AVSubtitleRect.pict.data by itself.
> >  
> 
> Patch looks fine, however I'm curious about this - does ffplay free
> data that was allocated by avcodec, and is supposed to be free'ed by
> avcodec? That seems rather risky API usage wise.

I'd say this would be plain invalid API usage. (Which is also why I
wanted to have the image data as AVFrame - free refcounting.)