[FFmpeg-devel] [PATCH v2 2/8] configure: Add version check for libkvazaar

[Arttu Ylä-Outinen]

On 2015-09-29 22:42, Hendrik Leppkes wrote:
> On Tue, Sep 29, 2015 at 9:39 PM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
>> Clément Bœsch <u <at> pkh.me> writes:
>>
>>>> +             { check_cpp_condition kvazaar.h "KVZ_API_VERSION >= 7" ||
>>>> +               die "ERROR: kvazaar API version must be at least 7."; }
>>> Can you do something like require_pkg_config "kvazaar >= 1.2.3" instead?
>> Please don't!
>> This only adds an unneeded requirement (and a regression)
>> to the library
> It already requires pkg-config, all Clement is asking to also use it
> to check the version, which makes a lot of sense.
> Its also much more visible for users. API versions aren't meaningful
> to users, while actual library versions are.

I'll change the patch to use pkg-config for the version check then.

Thanks for the comments.

- Arttu