[FFmpeg-devel] Libavcodec/exr : add support for tile

[Paul B Mahol]

On 4/3/16, Martin Vignali <martin.vignali at gmail.com> wrote:
> 2016-04-03 17:12 GMT+02:00 Paul B Mahol <onemda at gmail.com>:
>
>> On 4/3/16, Martin Vignali <martin.vignali at gmail.com> wrote:
>> > Hello,
>> >
>> > In attach a patch in order to add support for exr Tile (One Level)
>> >
>> > Some samples can be found here : https://we.tl/IC4XTrEJf4
>> > Theses samples can also be add to ./fate-suite/exr/
>> > (i will make a fate test soon).
>> >
>> > Details of the sample files :
>> > rgb_tile_half_raw_12x8.exr : uncompress half float file, in tile (only
>> one
>> > tile in the file)
>> > rgb_tile_float_raw_12x8.exr : uncompress float file, in tile (only one
>> tile
>> > in the file)
>> > rgb_tile_float_raw_150x130.exr : uncompress float file, in tile
>> > (multiple
>> > tile in the file)
>> >
>> > In this patch, compression in tile is not enabled. (i will make new
>> patchs
>> > for that after making more tests)
>> >
>> > I tried to keep the most code common with the scanline mode (reason why,
>> > scanline code part have had some modifications).
>> > Tile data are reorganized, to be more like scanline uncompress data.
>> >
>> > Pass fate-exr tests.
>> >
>> > More information about tile in exr can be found here :
>> > http://www.openexr.com/TechnicalIntroduction.pdf
>> >
>> > Comments welcome.
>> >
>> > Martin
>> > Jokyo Images
>> >
>>
>> Pushed. Note that tile with PIZ compression crashes
>>
>
> Thanks.
>
> With this patch, i not enable compression support in tile (i will make it
> sooner, in another patch).
> So PIZ Tile, should write an error message like that ("Compression in tile
> 4 is not implemented....")
> (I just test with a little sample).
>
> If it's really crash, this is another issue, can you send me the sample ?

I disabled the check... The zip compression works though.

>
> In all cases, i think PIZ decompress have some trouble for now (artefac and
> decoding error), need to look more closely...

Yes it's buggy, I'm aware of it.