[FFmpeg-devel] [PATCH 1/2] avfilter: add readvitc filter

[Carl Eugen Hoyos]

Tobias Rapp <t.rapp <at> noa-archive.com> writes:

> + <at> item thr_b
> +Set the luma threshold for black. Accepts float numbers in 
> the range [0.0,1.0],
> +default value is  <at> code{0.2}. The value must be smaller 
> than  <at> code{thr_w}.
> +
> + <at> item thr_w
> +Set the luma threshold for white. Accepts float numbers in 
> the range [0.0,1.0],
> +default value is  <at> code{0.6}. The value must be larger 
> than  <at> code{thr_b}.

I believe it would make sense to (slightly) change this 
logic so the user can specify 0.5 both for black and 
white and would get a documented behaviour.

> +    crc ^= ((line[0] >> 6) | 0x04 | (line[1] << 4));

Very minor comment: At least some of the parentheses 
should be unneeded.
(Actually all after checking again.)

Carl Eugen