[FFmpeg-devel] libavcodec/exr : Fix channel detection

[Carl Eugen Hoyos]

Martin Vignali <martin.vignali <at> gmail.com> writes:

> -        line = AV_RL32(src - 8);
> +        line = (int32_t)AV_RL32(src - 8);

This change is ugly and should be unneeded.

> +    channel_buffer[0] += channelLineSize * line_to_skip;
> +    channel_buffer[1] += channelLineSize * line_to_skip;
> +    channel_buffer[2] += channelLineSize * line_to_skip;
> +    if (channel_buffer[3])
> +        channel_buffer[3] += channelLineSize * line_to_skip;

> +        channel_buffer[0] += channelLineSize;
> +        channel_buffer[1] += channelLineSize;
> +        channel_buffer[2] += channelLineSize;
> +        if (channel_buffer[3])
> +            channel_buffer[3] += channelLineSize;

for() loops?

> +    if (s->pixel_type == EXR_HALF)
> +        s->pixel_size = 2;
> +    else
> +        s->pixel_size = 4;
> +

Please add braces.

Feel free to ignore if you disagree.

Carl Eugen