[FFmpeg-devel] [PATCH] hevc: Fix memory leak related to a53_caption data

[Will Kelleher]

On 04/08, Michael Niedermayer wrote:
> 
> > The a53_caption buffer is normally realloc'd when each sei_nal is
> > parsed, and then freed after it gets written to the output frame's
> > side data in hevc_frame_start.
> 
> and if an error happens between it leaks ?
> 

If an error occurred after sei nal parsing but before the data was
written to the output frame's side_data, it would just stay on the
context and get appended to when the following frame's sei nals get
parsed, and then the combined caption data of two frames would be
attached to the second output frame, I think.

> 
> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> Republics decline into democracies and democracies degenerate into
> despotisms. -- Aristotle



> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fffmpeg.org%2fmailman%2flistinfo%2fffmpeg-devel&data=01%7c01%7cwkelleher%40gogoair.com%7c3e503666e20747c6527b08d35fe70a88%7c2e6508518649457ea18abc0264c3b7d0%7c1&sdata=nm%2fxZTmRDJUqGdULOjHD3BWUUjwqIOAtogX7TW%2baMs4%3d