[FFmpeg-devel] [PATCH] Define service_type "HEVC digital television service (0x1F) in mpegtsenc.c

[Nicolas George]

Le tridi 3 floréal, an CCXXIV, Ali KIZIL a écrit :
> From 20c0ac586cf5056bcc057e7664a64ddfdc0e13f9 Mon Sep 17 00:00:00 2001
> From: smallishzulu <alikizil at gmail.com>
> Date: Thu, 21 Apr 2016 15:40:09 +0300
> Subject: [PATCH] Define service_type "HEVC digital television service"
>  (0x1F) in mpegtsenc.c
> 
> ---
>  libavformat/mpegtsenc.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c
> index f4cb862..9222665 100644
> --- a/libavformat/mpegtsenc.c
> +++ b/libavformat/mpegtsenc.c
> @@ -67,7 +67,8 @@ enum {
>      MPEGTS_SERVICE_TYPE_ADVANCED_CODEC_DIGITAL_RADIO = 0x0A,
>      MPEGTS_SERVICE_TYPE_MPEG2_DIGITAL_HDTV           = 0x11,
>      MPEGTS_SERVICE_TYPE_ADVANCED_CODEC_DIGITAL_SDTV  = 0x16,

> -    MPEGTS_SERVICE_TYPE_ADVANCED_CODEC_DIGITAL_HDTV  = 0x19
> +    MPEGTS_SERVICE_TYPE_ADVANCED_CODEC_DIGITAL_HDTV  = 0x19,
> +    MPEGTS_SERVICE_TYPE_HEVC_DIGITAL_HDTV            = 0x1F

Please add a final coma to avoid similar interference in the future. The
final coma should have already been present.

>  };
>  typedef struct MpegTSWrite {
>      const AVClass *av_class;
> @@ -1814,6 +1815,9 @@ static const AVOption options[] = {
>      { "advanced_codec_digital_hdtv", "Advanced Codec Digital HDTV.",
>        0, AV_OPT_TYPE_CONST, { .i64 =
> MPEGTS_SERVICE_TYPE_ADVANCED_CODEC_DIGITAL_HDTV }, 0x01, 0xff,
>        AV_OPT_FLAG_ENCODING_PARAM, "mpegts_service_type" },
> +    { "hevc_digital_hdtv", "HEVC Digital Television Service.",

> +      0, AV_OPT_TYPE_CONST, { .i64 = MPEGTS_SERVICE_TYPE_HEVC_DIGITAL_HDTV
> }, 0x01, 0xff,

The patch has been mangled by your mail software.

> +      AV_OPT_FLAG_ENCODING_PARAM, "mpegts_service_type" },
>      { "mpegts_pmt_start_pid", "Set the first pid of the PMT.",
>        offsetof(MpegTSWrite, pmt_start_pid), AV_OPT_TYPE_INT,
>        { .i64 = 0x1000 }, 0x0010, 0x1f00, AV_OPT_FLAG_ENCODING_PARAM },
> --
> 1.9.1
> 
> 

> The contents of this e-mail are confidential to the addressee and are
> intended solely for the recipients use. If you are not the addressee, you
> have received this e-mail in error. Any disclosure, copying, distribution
> or action taken in reliance on it is prohibited and may be unlawful. Please
> note that any opinions expressed in this e-mail are those of the author
> personally and not your business name who do not accept responsibility for
> the contents of the message.
> 
> To conserve our resources for the future please reconsider before printing
> this e-mail.

This makes no sense, especially on a public mailing-list.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160421/b95d7444/attachment.sig>