[FFmpeg-devel] [PATCH] avcodec: don't include vdpau_compat.h when vdpau is not enabled

Carl Eugen Hoyos ceffmpeg at gmail.com
Thu Aug 4 10:23:28 EEST 2016


2016-08-04 1:35 GMT+02:00 James Almer <jamrial at gmail.com>:
> On 8/3/2016 7:59 PM, Carl Eugen Hoyos wrote:
>> Hi!
>>
>> 2016-08-04 0:33 GMT+02:00 James Almer <jamrial at gmail.com>:
>>> This removes unnecessary header dependencies.
>>
>> Why is this an advantage?
>
> h263, vc1 and mpeg decoder were pointlessly pulling the entire set
> of h264 headers because of it.

So the advantage is that compilation gets measurably faster
with your patch?

Preprocessor checks instead of conditions have the disadvantage
that less syntax checking is done in some cases.

Thank you, Carl Eugen


More information about the ffmpeg-devel mailing list