[FFmpeg-devel] [PATCH 1/2] aacenc: add a faster version of twoloop as the "fast" coder

[Rostislav Pehlivanov]

On 7 August 2016 at 14:38, Moritz Barsnick <barsnick at gmx.net> wrote:

> On Sun, Aug 07, 2016 at 00:51:29 +0100, Rostislav Pehlivanov wrote:
> > +    //XXX: some heuristic to determine initial quantizers will reduce
> search time
>
> Is the "XXX" trying to tell someone something?
>
> > +        for (g = 0;  g < sce->ics.num_swb; g++) {
>
> I detect a spurious space in there. ;-) (This happens five times
> throughout your patch, BTW.)
>
>
The patch is a relatively untouched version of the old twoloop coder, so
anything that was there was left there. I'll remove the spaces when pushing.


> >      [AAC_CODER_FAST] = {
> >          search_for_quantizers_fast,
> > -        encode_window_bands_info,
> > +        codebook_trellis_rate,
> >          quantize_and_encode_band,
> >          ff_aac_encode_tns_info,
> >          ff_aac_encode_ltp_info,
>
> Without understanding the code: Is this change related or even desired?
>
>
Related, desired and needed. Twoloop only supports
codebook_trellis_rate. encode_window_bands_info()
is very limited in terms of features, quality and an absolute pain to
maintain, the second ANMR gets ported to support codebook_trellis_rate it
will be removed.

Also I just noticed the caching system for the RDO function is unneeded
here since it gets called once per window+group. I'll remove that too when
pusing.