[FFmpeg-devel] [PATCHv2] af_hdcd: Don't warn if converting from AV_SAMPLE_FMT_S16P

Nicolas George george at nsup.org
Mon Aug 8 00:04:51 EEST 2016

Le primidi 21 thermidor, an CCXXIV, Burt P. a écrit :
> The HDCD codes are stored in the LSB of consecutive samples, and
> anything that would change a sample could cause problems. So it looks
> through the AVFilterLink chain and warns if any resampling or
> truncation is happening that might destroy the HDCD code before or
> undo the filter's work after.

I understand the concern, but intruding in other filters is really outside
from lavfi's design. Just to illustrate this point, the tests as they are
could call av_get_sample_fmt_name() on something that is not a sample

You can advise users to disable automatic conversions when using this filter
(there is an API for that, but I think there is no user interface yet), but
beyond that the policy should be to always leave enough rope to shoot
oneself in the foot.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160807/fe2f2d41/attachment.sig>

More information about the ffmpeg-devel mailing list