[FFmpeg-devel] [PATCHv2] af_hdcd: Don't warn if converting from AV_SAMPLE_FMT_S16P

[Nicolas George]

Le primidi 21 thermidor, an CCXXIV, Burt P. a écrit :
> Are you now talking about plans of the future or this specific case?

Both.

> As it is, automatic conversion is very helpful, for example from
> WavePack, which uses s16p.

Apparently, not all of them are to your liking. FFmpeg can not guess which
ones. You could try to teach it, but it may prove tricky. The best solution
is to let the user choose, and that is exactly what disabling the automatic
conversion does.

Note that it does not disable conversions, only automatic ones. It also does
not disable format negotiation. The only thing that changes is that the user
has to choose where the conversion happens.

> This filter is only looking at the AVFilterLinks between filters, not
> at the filters themselves.

And with lavfi's design, this is not allowed. As is, the filter is scanning
links that it does not even know are audio, let alone are in any way
connected to it.

> This scan and warn behavior was added to address a real issue.

That is more or less the Transportation Security Administration's motto, and
we all know what a catastrophe that is. Good intentions are not enough to
make a solution correct, and this solution is not correct at all.

> Consider these example cases:

None of them involve anything remotely complicated.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160808/3331ce43/attachment.sig>