[FFmpeg-devel] [PATCH 4/4] lavf/mov: Add support for edit list parsing.

Sasi Inguva isasi at google.com
Wed Aug 10 20:14:43 EEST 2016


Oops. I forgot to git add the new test ref files. Please find attached, the
modified patch. Will also send it through git send-email.

On Wed, Aug 10, 2016 at 8:23 AM, Michael Niedermayer <michael at niedermayer.cc
> wrote:

> On Tue, Aug 09, 2016 at 06:48:22PM -0700, Sasi Inguva wrote:
> > Signed-off-by: Sasi Inguva <isasi at google.com>
> > ---
> >  libavformat/mov.c                            |  323 ++++++++-
> >  tests/Makefile                               |    1 +
> >  tests/fate/mov.mak                           |   28 +
> >  tests/ref/fate/filter-fps-cfr                |    1 -
> >  tests/ref/fate/gaplessenc-itunes-to-ipod-aac |   12 +-
> >  tests/ref/fate/gaplessenc-pcm-to-mov-aac     |   12 +-
> >  tests/ref/fate/gsm-toast                     | 1000
> +++++++++++++-------------
> >  tests/ref/fate/h264-invalid-ref-mod          |   20 +-
> >  tests/ref/fate/pcm_s16be-stereo              |    2 +-
> >  tests/ref/fate/quickdraw                     |   12 +-
> >  tests/ref/fate/tscc2-mov                     |   20 +-
> >  tests/ref/lavf-fate/mov_qtrle_mace6          |    2 +-
> >  12 files changed, 884 insertions(+), 549 deletions(-)
> >  create mode 100644 tests/fate/mov.mak
>
> make fate-mov-elist-starts-ctts-2ndsample
> TEST    mov-elist-starts-ctts-2ndsample
> reference file './tests/ref/fate/mov-elist-starts-ctts-2ndsample' not
> found
>
> also gcc produces quite a few warnings:
>
> libavformat/isom.c: In function ‘ff_mp4_read_dec_config_descr’:
> libavformat/isom.c:482:14: warning: variable ‘v’ set but not used
> [-Wunused-but-set-variable]
> libavformat/mov.c: In function ‘mov_fix_index’:
> libavformat/mov.c:2951:16: warning: format ‘%lld’ expects argument of type
> ‘long long int’, but argument 5 has type ‘int64_t’ [-Wformat]
> libavformat/mov.c:2951:16: warning: format ‘%lld’ expects argument of type
> ‘long long int’, but argument 6 has type ‘int64_t’ [-Wformat]
> libavformat/mov.c:2951:16: warning: format ‘%lld’ expects argument of type
> ‘long long int’, but argument 7 has type ‘int64_t’ [-Wformat]
> libavformat/mov.c:3014:24: warning: format ‘%lld’ expects argument of type
> ‘long long int’, but argument 4 has type ‘int64_t’ [-Wformat]
> libavformat/mov.c:3014:24: warning: format ‘%lld’ expects argument of type
> ‘long long int’, but argument 5 has type ‘int64_t’ [-Wformat]
> libavformat/mov.c:3014:24: warning: format ‘%lld’ expects argument of type
> ‘long long int’, but argument 7 has type ‘int64_t’ [-Wformat]
> libavformat/mov.c:3021:40: warning: passing argument 2 of ‘add_ctts_entry’
> from incompatible pointer type [enabled by default]
> libavformat/mov.c:2860:16: note: expected ‘int64_t *’ but argument is of
> type ‘unsigned int *’
> libavformat/mov.c:3025:32: warning: format ‘%lld’ expects argument of type
> ‘long long int’, but argument 4 has type ‘int64_t’ [-Wformat]
> libavformat/mov.c:3025:32: warning: format ‘%lld’ expects argument of type
> ‘long long int’, but argument 5 has type ‘int64_t’ [-Wformat]
> libavformat/mov.c:3025:32: warning: format ‘%lld’ expects argument of type
> ‘long long int’, but argument 6 has type ‘int’ [-Wformat]
> libavformat/mov.c:3035:17: warning: format ‘%lld’ expects argument of type
> ‘long long int’, but argument 4 has type ‘int64_t’ [-Wformat]
> libavformat/mov.c:3035:17: warning: format ‘%lld’ expects argument of type
> ‘long long int’, but argument 5 has type ‘int64_t’ [-Wformat]
> libavformat/mov.c:3059:40: warning: passing argument 2 of ‘add_ctts_entry’
> from incompatible pointer type [enabled by default]
> libavformat/mov.c:2860:16: note: expected ‘int64_t *’ but argument is of
> type ‘unsigned int *’
> libavformat/mov.c:3062:32: warning: format ‘%lld’ expects argument of type
> ‘long long int’, but argument 4 has type ‘int64_t’ [-Wformat]
> libavformat/mov.c:3062:32: warning: format ‘%lld’ expects argument of type
> ‘long long int’, but argument 5 has type ‘int64_t’ [-Wformat]
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> The educated differ from the uneducated as much as the living from the
> dead. -- Aristotle
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-lavf-mov-Add-support-for-edit-list-parsing.patch
Type: text/x-patch
Size: 116868 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160810/6c6f0559/attachment.bin>


More information about the ffmpeg-devel mailing list