[FFmpeg-devel] [PATCH] af_volumedetect: Work with sample formats other than s16/s16p

Burt P. pburt0 at gmail.com
Sat Aug 13 21:55:06 EEST 2016


Thanks, I will use astats instead.

On Sat, Aug 13, 2016 at 4:23 AM, Paul B Mahol <onemda at gmail.com> wrote:
> On 8/13/16, Nicolas George <george at nsup.org> wrote:
>> Le septidi 27 thermidor, an CCXXIV, Burt P a écrit :
>>> The histogram will still only be shown for s16 and s16p.
>>>
>>> Signed-off-by: Burt P <pburt0 at gmail.com>
>>> ---
>>>  libavfilter/af_volumedetect.c | 133
>>> ++++++++++++++++++++++++++++++++++++++----
>>>  1 file changed, 121 insertions(+), 12 deletions(-)
>>
>> Did you benchmark the original s16 case? The main point of this filter is
>> that it is fast. With these changes, I see switches inside inner loops, and
>> I am afraid it becomes less fast.
>
> Also, swresample already does what converting code do, but faster.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel



-- 
Burt


More information about the ffmpeg-devel mailing list