[FFmpeg-devel] [PATCH 0/3] libhdcd and things

James Almer jamrial at gmail.com
Tue Aug 23 03:52:18 EEST 2016

On 8/22/2016 8:01 PM, Burt P wrote:
> I have created a stand-alone library of the HDCD decoder from af_hdcd,
> and called it libhdcd. [ https://github.com/bp0/libhdcd ]

A couple comments about the library.

-The name hdcd_decode2 is still used in some places after your rename
commit, like the installed header and main c file.
-Does every struct currently defined in the installed header need to be
there? Most if not all of the stuff in both hdcd_state_* structs kinda
look like it could be internal, much like it currently is in af_hdcd.c
You can play around with the API until you tag a first release.
-Make the flags field int and update the relevant function signatures.
You may not intend to add new flags now, but you may in the future, and
uint8_t is too small for that.
-Make sure it builds a shared library and symbols are visible.
-Some doxy for the public functions would be nice.

> I hope to use it in patches/plugins to some media players, and still
> be able to easily maintain them both together. 
> There is some concern that I wanted to remove the native code from the 
> filter and use a wrapper of libhdcd, and I did think about that, but  
> after comments on #ffmpeg-devel and in e-mail, I am convinced that is
> wrong. I submitted a wrapper version to libav, however, as it was their
> suggestion to do it that way to begin with.
> The series also includes a couple small patches, self-described.
> Thanks for comments.
> --
> Burt
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

More information about the ffmpeg-devel mailing list