[FFmpeg-devel] [PATCH 3/3] af_hdcd: for easier maintenance alongside libhdcd

Carl Eugen Hoyos ceffmpeg at gmail.com
Tue Aug 23 22:29:20 EEST 2016


2016-08-23 1:01 GMT+02:00 Burt P <pburt0 at gmail.com>:

> +    int channel_count = av_get_channel_layout_nb_channels(inlink->channel_layout);

It seems safer to me to use the actual number of channels than the
channel layout.

(Or to say it differently: It is most likely a bug that FFmpeg tries
hard to guess a
channel format for every input, there are use cases where channels do not have a
layout and no part of the transcoding chain needs one. Please don't
rely on this bug.)

I would suggest to split the purely cosmetic changes that move code or
around from actual changes to the code.

Thank you, Carl Eugen

More information about the ffmpeg-devel mailing list