[FFmpeg-devel] [PATCH 18/21] libavformat/movenc: mov_write_audio_tag writes the proper number of channels, not the hardcoded 2

Erkki Seppälä erkki.seppala.ext at nokia.com
Wed Aug 24 10:14:30 EEST 2016

On 08/23/2016 06:20 PM, Yusuke Nakamura wrote:
>> -            avio_wb16(pb, 2);
>> +            avio_wb16(pb, track->par->channels);
> No. the ChannelCount field is templated. It may be fixed to 2 by derived
> specs or the specs of codec encapsulations. I mean the current
> implemetation is wrong, and your implementation is also wrong. For
> instance, ChannelCount of AC-3 in ISOBMFF is always hardcoded to 2 even if
> 5.1ch. This field is basically not useful for ISOBMFF and the actual
> channels shall be referred to Codec specific info.

It seems the part of the standard didn't give the full view on the 
matter. This patch can be dropped.

Thanks for the review!

More information about the ffmpeg-devel mailing list