[FFmpeg-devel] [PATCH] mov: Remove ancient heuristic hack

[Carl Eugen Hoyos]

Hi Derek!

2016-08-24 16:55 GMT+02:00 Derek Buitenhuis <derek.buitenhuis at gmail.com>:
> This breaks files with legitimate single-entry edit lists,
> and the hack, introduced in f03a081df09f9c4798a17d7e24446ed47924b11b,
> has no link to any known sample in its commit message, nor

I suspect the commit message links to this sample:
http://samples.ffmpeg.org/ffmpeg-bugs/roundup/issue910/

This reminds me that we should try to find the roundup mailing
list archives, I don't think there is an online copy anymore;-(

> does it actually fix the problem properly, but instead has
> a one-off heuristic to try and "fix" them at the expense
> of breaking legitimate files.

Please remove the personal aspects from your commit message.

[...}

> Example file:
>     http://chromashift.org/samples/delay_problem.mp4
>
> Having the DTS delay output on the first packet itself
> is important for things like cutting files.
>
> The behavioral change can be seen with:
>     $ ffprobe -show_packets delay_problem.mp4

Could you explain in a less technical way (for me to understand)
what is wrong with FFmpeg and this file currently?

Thank you, Carl Eugen